Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for #1646 (permission issues on local files) #1648

Merged
merged 3 commits into from
Nov 18, 2015
Merged

Add integration tests for #1646 (permission issues on local files) #1648

merged 3 commits into from
Nov 18, 2015

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Nov 17, 2015

This PR pulls in #1646 and adds an additional commit that includes integration tests for extra test coverage. It also shows we have consistent behavior from multipart vs. non-multipart uploads. Would like a quick review on the integration tests.

cc @kyleknap @mtdowling @rayluo @JordonPhillips

@jamesls jamesls added the pr:needs-review This PR needs a review from a Member. label Nov 17, 2015
@jamesls jamesls mentioned this pull request Nov 17, 2015
Closed
@jamesls
Copy link
Member Author

jamesls commented Nov 17, 2015

Confirmed:

fixes #1645
fixes #1442

@JordonPhillips
Copy link
Member

🚢

@kyleknap
Copy link
Contributor

LGTM 🚢. Thanks @phss!

@jamesls jamesls merged commit 5a9d182 into aws:develop Nov 18, 2015
@jamesls jamesls mentioned this pull request Nov 18, 2015
Closed
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@dkryptr @sanathkr
feat(CORS): Set the CORS "Access-Control-Allow-Credentials" for local…
cd3ec84 
… running (aws#1648)
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
@sanathkr @jfuss
Revert "feat(CORS): Set the CORS "Access-Control-Allow-Credentials" f…
bc68c21 
…or local running (aws#1648)" (aws#1664)

This reverts commit cd3ec84.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:needs-review This PR needs a review from a Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesls @JordonPhillips @kyleknap @phss